get rid of IsVirtual field #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -52,3 +48,9 @@ func (i *Info) ActualInterfaceName() string { | |||
| } | |||
| return i.InterfaceName | |||
| } | |||
|
|
|||
| // IsVirtual returns true when the interface is a virtual device, as | |||
|
LGTM with a few small changes, extracting TestAll(t *testing.T) in package_test and renaming the suite to InfoSuite. |
added 2 commits
June 12, 2014 11:38
|
|
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
jujubot
added a commit
that referenced
this pull request
Jun 12, 2014
get rid of IsVirtual field network: get rid of IsVirtual field The field IsVirtual is redundant in NetworkInfo and network.Info structs, the value may be inferred from the value of VLANTag field.
ericsnowcurrently
pushed a commit
to ericsnowcurrently/juju
that referenced
this pull request
May 26, 2015
migratebundle: new package
hmlanigan
pushed a commit
to hmlanigan/juju
that referenced
this pull request
Aug 26, 2019
MAAS2: handle fields that might be missing or null from the API I asked the MAAS team to look through a list of all the fields that we're using in the MAAS v2 API and tell us which of them were optional or nullable. These changes are based on the information they gave us back. Based on the spreadsheet here: https://docs.google.com/a/canonical.com/spreadsheets/d/1qysFkvJwz3w19B3kYcnlokwqdTb82HGCrF4pUk6gtfA/edit?usp=sharing
laszlokajtar
pushed a commit
to laszlokajtar/juju
that referenced
this pull request
Oct 25, 2023
Update to gevent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
network: get rid of IsVirtual field
The field IsVirtual is redundant in NetworkInfo and network.Info structs,
the value may be inferred from the value of VLANTag field.