New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed lp:1574844: juju2 gives ipv6 address for one lxd, rabbit doesn't appreciate it. #5435
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimitern
force-pushed
the
lp-1574844-preferred-addrs-ipv6-2
branch
from
May 23, 2016 08:49
5af869a
to
806a3f4
Compare
Closing this as it was superseded by #5471 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preferred private and public addresses of the machines are now stored
separetely for IPv4 and IPv6. PrivateAddress() and PublicAddress()
methods on both the state.Machine and state.Unit now return the
preferred IPv4 address, if available, otherwise fall back to the
preferred IPv6 address (if available, otherwise returns NoAddressError).
See http://pad.lv/1574844/ for more information.
Live tested on LXD deploying 20 ubuntu units and watching the IP
addresses the machines and units eventually get.
(Review request: http://reviews.vapour.ws/r/4871/)