apiserver: fix data race on tls config #5455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes LP 1518806 Fixes LP 1519097 Pass a _copy_ of the current TLS config to the TLS server for the accepted connection. This fixes a race where updateCertificate may mutate its config, a reference to which has been passed to _all_ the active TLS connections. This bug is at the bottom of a chain of other data race blockers so we can remove a bunch of test skips under the race detector.
|
|
1 similar comment
|
|
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
|
Build failed: Does not match ['fixes-1577945'] |
|
|
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
|
Build failed: Tests failed |
|
|
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
|
Build failed: Tests failed |
|
|
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes LP 1518806
Fixes LP 1519097
Pass a copy of the current TLS config to the TLS server for the
accepted connection. This fixes a race where updateCertificate may
mutate its config, a reference to which has been passed to all the
active TLS connections.
This bug is at the bottom of a chain of other data race blockers so we
can remove a bunch of test skips under the race detector.
(Review request: http://reviews.vapour.ws/r/4896/)