/juju

apiserver: fix data race on tls config #5455

Merged
merged 1 commit into from May 26, 2016

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@davecheney @jujubot
@davecheney
Contributor

davecheney commented May 25, 2016 •
Edited 1 time

Fixes LP 1518806
Fixes LP 1519097

Pass a copy of the current TLS config to the TLS server for the
accepted connection. This fixes a race where updateCertificate may
mutate its config, a reference to which has been passed to all the
active TLS connections.

This bug is at the bottom of a chain of other data race blockers so we
can remove a bunch of test skips under the race detector.

(Review request: http://reviews.vapour.ws/r/4896/)
@davecheney
apiserver: fix data race on tls config 
Fixes LP 1518806
Fixes LP 1519097

Pass a _copy_ of the current TLS config to the TLS server for the
accepted connection. This fixes a race where updateCertificate may
mutate its config, a reference to which has been passed to _all_ the
active TLS connections.

This bug is at the bottom of a chain of other data race blockers so we
can remove a bunch of test skips under the race detector.
17f05e8
@davecheney
Contributor

davecheney commented May 25, 2016

$$merge$$
@davecheney
Contributor

davecheney commented May 25, 2016

$$merge$$
@jujubot
Contributor

jujubot commented May 25, 2016

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju
@jujubot
Contributor

jujubot commented May 25, 2016

Build failed: Does not match ['fixes-1577945']
build url: http://juju-ci.vapour.ws:8080/job/github-merge-juju/7863
@davecheney
Contributor

davecheney commented May 26, 2016

$$fixes-1518806$$
@jujubot
Contributor

jujubot commented May 26, 2016

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju
@jujubot
Contributor

jujubot commented May 26, 2016

Build failed: Tests failed
build url: http://juju-ci.vapour.ws:8080/job/github-merge-juju/7864
@davecheney
Contributor

davecheney commented May 26, 2016

$$fixes-1518806$$
@jujubot
Contributor

jujubot commented May 26, 2016

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju
@jujubot
Contributor

jujubot commented May 26, 2016

Build failed: Tests failed
build url: http://juju-ci.vapour.ws:8080/job/github-merge-juju/7865
@davecheney
Contributor

davecheney commented May 26, 2016

$$fixes-1518806$$
@jujubot
Contributor

jujubot commented May 26, 2016

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

@jujubot jujubot merged commit 9fb1a31 into juju:master May 26, 2016

@davecheney davecheney deleted the davecheney:fixedbugs/1518806 branch May 26, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment