state/presence: cleanups for issue 1588574 #5530
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes LP 1588574 The `panic: session already closed` comes from a watcher or pinger that is still running when the test case returns to TearDownTest. This happens because while we always call w.Stop in a defer, w.Stop does not actually stop the worker, it just asks it to stop. To ensure the worker is stopped, introduce a new function `assertStopped` which stops a worker and waits until it reports stopped. This method should be used in favor of defer w.Stop() because you _must_ ensure that all workers that share a mongo connection (which is _all_ of them) have stopped, and thus are no longer using a mgo session before `TearDownTest` shuts down the connection. Because this pattern of stopping and not waiting was common to both the pinter and watcher tests, and is now resolved, we can remove the `recover` in the `ping()` method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates LP # 1588574
This PR applies some cleanups to
state/presenceuncovered during the investigation of 1588574. The main change is the removal of the panic -> error logic inping. Honestly, if the mongo driver panics, we need to fix that problem, not brush it under the rug.BaseSuiteKillForTestinghelper toexport_test.goping, this practice is questionable, especially as it is not applied in the identicalsyncpath.(Review request: http://reviews.vapour.ws/r/4977/)