Fixes lp#1576003: Double default bootstrap timeout for maas. #5638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y: use user provided when a user supplies one; otherwise use MAAS provider specific default whcih is different to all other providers default. Added tests to check: 1. When bootstrap timeout is not specified, a default is used; 2. When user specifies bootstrap timeout that value is used; 3. and user specified value is used even if it's less than MAAS default value.
|
|
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bootstrap-timeout is a duration that is highly provider specific.
We do well with common timeout defaults on all providers except for MAAS. Juju users bootstraping on MAAS have to overwrite default time in configuration for each controller deployment. More details in the bug.
This PR improves user experience with Juju on MAAS.
(Review request: http://reviews.vapour.ws/r/5082/)