Replace agent machine lock with juju/mutex #5659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This work completely removes all use of fslock from the juju core codebase. The uniter hook execution log is now a named juju/mutex. The name is defined as a constant in the agent package, and passed to the workers that need it as manifold configuration. The jujuclient store fslock is replaced with a global mutex. Since this mutex is only guarding around very bried read or write operations to a file, a system lock will have no appreciable difference to a user. A follow up branch could fix this should it become a real problem (which I don't think it will).
howbazaar
force-pushed
the
replace-agent-machine-lock-with-mutex
branch
from
09c8643
to
4bf3160
Compare
|
$$JFDI$$ this really needs to get in. fslock has caused us so much pain. |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
|
Build failed: Tests failed |
|
|
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
jujubot
added a commit
that referenced
this pull request
Jun 20, 2016
…th-mutex Replace agent machine lock with juju/mutex This work completely removes all use of fslock from the juju core codebase. The uniter hook execution log is now a named juju/mutex. The name is defined as a constant in the agent package, and passed to the workers that need it as manifold configuration. The jujuclient store fslock is replaced with a global mutex. Since this mutex is only guarding around very bried read or write operations to a file, a system lock will have no appreciable difference to a user. A follow up branch could fix this should it become a real problem (which I don't think it will). (Review request: http://reviews.vapour.ws/r/5103/)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This work completely removes all use of fslock from the juju core codebase.
The uniter hook execution log is now a named juju/mutex. The name is defined as a constant in the agent package, and passed to the workers that need it as manifold configuration.
The jujuclient store fslock is replaced with a global mutex. Since this mutex is only guarding around very bried read or write operations to a file, a system lock will have no appreciable difference to a user. A follow up branch could fix this should it become a real problem (which I don't think it will).
(Review request: http://reviews.vapour.ws/r/5103/)