Replace hook execution fslock with mutex implementation. #5663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This work completely removes all use of fslock from the juju core codebase. The uniter hook execution lock is now a named juju/mutex. The name is defined as a constant in the agent package, and passed to the workers that need it as manifold configuration for those that have manifolds, or as params to those that don't.
howbazaar
force-pushed
the
1.25-replace-agent-machine-lock-with-mutex
branch
from
d48788d
to
8e9561d
Compare
|
$$JFDI$$ can't find the 1.25 bug, but this causes real problems. |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This work completely removes all use of fslock from the juju core codebase.
The uniter hook execution lock is now a named juju/mutex. The name is defined as a constant in the agent package, and passed to the workers that need it as manifold configuration for those that have manifolds, or as params to those that don't.
(Review request: http://reviews.vapour.ws/r/5107/)