Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

charm: avoid use of /bin/cp #57

Merged
merged 2 commits into from Jun 10, 2014
Merged

Conversation

rogpeppe
Copy link
Contributor

Isolated tests should avoid use of external commands when possible.

Also update utils dependency so that we can use the new fs package
containing the Copy function.

Isolated tests should avoid use of external commands when possible.

Also update utils dependency so that we can use the new fs package
containing the Copy function.
@jameinel
Copy link
Member

LGTM

@rogpeppe
Copy link
Contributor Author

$$merge$$

@jujubot
Copy link
Collaborator

jujubot commented Jun 10, 2014

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

@frankban
Copy link
Member

LGTM thank you.

@jujubot
Copy link
Collaborator

jujubot commented Jun 10, 2014

Build failed: Tests failed
build url: http://juju-ci.vapour.ws:8080/job/github-merge-juju/77

@rogpeppe
Copy link
Contributor Author

$$merge$$

@jujubot
Copy link
Collaborator

jujubot commented Jun 10, 2014

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

jujubot added a commit that referenced this pull request Jun 10, 2014
Isolated tests should avoid use of external commands when possible.

Also update utils dependency so that we can use the new fs package
containing the Copy function.
@jujubot jujubot merged commit 57ebaa5 into juju:master Jun 10, 2014
ericsnowcurrently pushed a commit to ericsnowcurrently/juju that referenced this pull request May 26, 2015
Introduced meter-status-changed hook.
hmlanigan pushed a commit to hmlanigan/juju that referenced this pull request Aug 26, 2019
Enable reading and setting machine owner data

Expose owner data from the API - this is key/value storage that can be set by the owner of the machine and is cleared when the machine is released.

It's needed so Juju can to store controller/model information for instances without using the Storage interface.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants