New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
charm: avoid use of /bin/cp #57
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Isolated tests should avoid use of external commands when possible. Also update utils dependency so that we can use the new fs package containing the Copy function.
LGTM |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
LGTM thank you. |
Build failed: Tests failed |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
jujubot
added a commit
that referenced
this pull request
Jun 10, 2014
Isolated tests should avoid use of external commands when possible. Also update utils dependency so that we can use the new fs package containing the Copy function.
ericsnowcurrently
pushed a commit
to ericsnowcurrently/juju
that referenced
this pull request
May 26, 2015
Introduced meter-status-changed hook.
hmlanigan
pushed a commit
to hmlanigan/juju
that referenced
this pull request
Aug 26, 2019
Enable reading and setting machine owner data Expose owner data from the API - this is key/value storage that can be set by the owner of the machine and is cleared when the machine is released. It's needed so Juju can to store controller/model information for instances without using the Storage interface.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Isolated tests should avoid use of external commands when possible.
Also update utils dependency so that we can use the new fs package
containing the Copy function.