Move the ifdown/ifup logic to the interface definition file #572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
that the bridge_port is up before start the bridge this is a fix proposal for LP: #1341524 Signed-off-by: Jorge Niedbalski R <niedbalski@gmail.com>
| if err != nil { | ||
| return "", err | ||
| } | ||
|
|
There was a problem hiding this comment.
The above error check can be inlined.
if err = tpl.Execute(); err != nil {
return "", errors.Annotate(err, "cannot update interface names")
}
|
Thanks for this fix - it looks ok, but I do not have enough MAAS and network background to comment for sure. Can this please be tested live on a MAAS deployment to ensure it works as expected? |
| cat > /etc/network/interfaces.d/%s.cfg << EOF | ||
| func restoreInterfacesFiles(iface string) (string, error) { | ||
| return replaceInterface(`mkdir -p etc/network/interfaces.d | ||
| cat > /etc/network/interfaces.d/{{ .NetworkInterface }}.cfg << EOF |
There was a problem hiding this comment.
Should it be absolute or relative here? etc/network/interfaces.d vs. /etc/network/interfaces.d is inconsistent IMHO.
|
This PR Is not longer needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposed fix for https://bugs.launchpad.net/juju-core/+bug/1341524 , which is a specific issue caused by the 'ifdown interface' performed on the injected cloud-init, this change was introduced in favor of the previous 'service networking restart' as you can see performing a git diff -r 411dbff^! . This change was made because that command were killing dbus on the local provider.
So, my proposal is that instead of forcing the ifdown of the interface, we can use the network interface configuration to pass a set of pre-up command that brings the bridge and the associated interface up after configure it.
Please let me know any observation.
Signed-off-by: Jorge Niedbalski R niedbalski@gmail.com