Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Fixes lp#1597830: worker should not restart agent. #5746
Conversation
anastasiamac
added some commits
Jun 30, 2016
howbazaar
reviewed
Jun 30, 2016
| @@ -31,9 +32,8 @@ type converter struct { | ||
| machine machine | ||
| } | ||
| -// Agent is an interface that can have its password set and be told to restart. | ||
| +// Agent is an interface that can have its password set. |
|
LGTM |
|
(modulo tim's comment, but I'm happy) |
|
LGTM as well |
|
$$fixes-1597830$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
|
Build failed: Generating tarball failed |
|
Build failed: Generating tarball failed |
|
$$fixes-1597830$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
|
Build failed: Generating tarball failed |
|
$$fixes-1597830$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
|
Build failed: Generating tarball failed |
|
$$fixedit$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
|
Build failed: Generating tarball failed |
|
$$noreally$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
anastasiamac commentedJun 30, 2016
Xenial machines with units would hang when trying to convert to state servers under HA after new revisions of systemd and dbus were introduced.
It was discovered that the conv2state worker would explicitly restart an agent. This proposal changes the behavior to throw an error instead to ensure that proper infrastructure restarts the agent cleanly.