Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes lp#1597830: worker should not restart agent. #5746

Merged
merged 4 commits into from Jul 1, 2016
Merged

Fixes lp#1597830: worker should not restart agent. #5746

merged 4 commits into from Jul 1, 2016

Conversation

anastasiamac
Copy link
Contributor

Xenial machines with units would hang when trying to convert to state servers under HA after new revisions of systemd and dbus were introduced.

It was discovered that the conv2state worker would explicitly restart an agent. This proposal changes the behavior to throw an error instead to ensure that proper infrastructure restarts the agent cleanly.

howbazaar
howbazaar reviewed Jun 30, 2016
View reviewed changes
worker/conv2state/converter.go
@@ -31,9 +32,8 @@ type converter struct {
machine machine
}

// Agent is an interface that can have its password set and be told to restart.
// Agent is an interface that can have its password set.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment is still wrong, because all it has is Tag.

@fwereade
Copy link
Contributor

LGTM

@fwereade
Copy link
Contributor

(modulo tim's comment, but I'm happy)

@howbazaar
Copy link
Contributor

LGTM as well

@anastasiamac
Copy link
Contributor Author

$$fixes-1597830$$

@jujubot
Copy link
Collaborator

jujubot commented Jul 1, 2016

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

@jujubot
Copy link
Collaborator

jujubot commented Jul 1, 2016

Build failed: Generating tarball failed
build url: http://juju-ci.vapour.ws:8080/job/github-merge-juju/8331

@jujubot
Copy link
Collaborator

jujubot commented Jul 1, 2016

Build failed: Generating tarball failed
build url: http://juju-ci.vapour.ws:8080/job/github-merge-juju/8332

@anastasiamac
Copy link
Contributor Author

$$fixes-1597830$$

@jujubot
Copy link
Collaborator

jujubot commented Jul 1, 2016

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

@jujubot
Copy link
Collaborator

jujubot commented Jul 1, 2016

Build failed: Generating tarball failed
build url: http://juju-ci.vapour.ws:8080/job/github-merge-juju/8333

@anastasiamac
Copy link
Contributor Author

$$fixes-1597830$$

@jujubot
Copy link
Collaborator

jujubot commented Jul 1, 2016

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

@jujubot
Copy link
Collaborator

jujubot commented Jul 1, 2016

Build failed: Generating tarball failed
build url: http://juju-ci.vapour.ws:8080/job/github-merge-juju/8336

@bz2
Copy link
Contributor

bz2 commented Jul 1, 2016

$$fixedit$$

@jujubot
Copy link
Collaborator

jujubot commented Jul 1, 2016

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

@jujubot
Copy link
Collaborator

jujubot commented Jul 1, 2016

Build failed: Generating tarball failed
build url: http://juju-ci.vapour.ws:8080/job/github-merge-juju/8337

@bz2
Copy link
Contributor

bz2 commented Jul 1, 2016

$$noreally$$

@jujubot
Copy link
Collaborator

jujubot commented Jul 1, 2016

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

@jujubot jujubot merged commit 113572c into juju:1.25 Jul 1, 2016
@anastasiamac anastasiamac deleted the jobs-change-pickup branch July 1, 2016 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@anastasiamac @fwereade @howbazaar @jujubot @bz2