state: allow unused optional storage to be removed #5862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When switching/upgrading the charm for an application, we have been too strict when stores are removed from the charm metadata. If a store is marked optional, and is unused, its removal should not trigger failure. Fixes https://bugs.launchpad.net/juju-core/+bug/1599503
axw
force-pushed
the
lp1599503-upgradecharm-remove-unused-optional-storage
branch
from
b6e08a6
to
cf59cd5
Compare
|
|
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When switching/upgrading the charm for an application,
we have been too strict when stores are removed from
the charm metadata. If a store is marked optional,
and is unused, its removal should not trigger failure.
QA:
(which was reverted due to this bug)
There should be no errors.
Fixes https://bugs.launchpad.net/juju-core/+bug/1599503
(Review request: http://reviews.vapour.ws/r/5299/)