Replace the legacy backups implementation with a new one. #606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericsnowcurrently
force-pushed
the
backups-kill-legacy
branch
from
5af1bc8
to
67938fd
Compare
| dbSecret = "shared-secret" | ||
| ) | ||
|
|
||
| // GetFilesTOBackUp returns the paths that should be included in the |
|
The size of the PR is a bit overwhelming, but I think it looks fine in general. |
|
Yeah, sorry about the size of this one. Thanks for taking the time. |
| dbDumpDir = "dump" | ||
| ) | ||
|
|
||
| // Archive is used to represents the contents of a backup archive. |
ericsnowcurrently
force-pushed
the
backups-kill-legacy
branch
from
900626e
to
b93dd22
Compare
|
So, I have some nitpicks but it generally is fine, so I'll call it LGTM. |
|
|
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
jujubot
added a commit
that referenced
this pull request
Sep 8, 2014
Replace the legacy backups implementation with a new one. The new implementation is refactored to fit to the new backups approach of storing the backups in env storage (along with metadata in mongo). This is the final large patch in the backup series (the remaining ones are much smaller). The next 2 patches in the series: ericsnowcurrently#3 ericsnowcurrently#4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new implementation is refactored to fit to the new backups approach of storing the backups in env storage (along with metadata in mongo). This is the final large patch in the backup series (the remaining ones are much smaller).
The next 2 patches in the series:
ericsnowcurrently#3
ericsnowcurrently#4