Add machine undertaker worker #6082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| machineUndertakerName: ifNotMigrating(machineundertaker.Manifold(machineundertaker.ManifoldConfig{ | ||
| APICallerName: apiCallerName, | ||
| EnvironName: environTrackerName, | ||
| NewWorker: machineundertaker.NewWorker, |
There was a problem hiding this comment.
you are likely to find manifold testing a bit easier if you supply NewFacade as a dependency too
There was a problem hiding this comment.
I haven't done this, since I'd already written the tests for the manifold, and in this case it wasn't too hard to contrive to get an error out of the real API client.
babbageclunk
force-pushed
the
machine-undertaker
branch
2 times, most recently
from
49039b1
to
7467d55
Compare
Well, other than logging.
So I can test worker setup.
No tests yet.
... rather than waiting for the machine to be removed. Also a drive-by fix of some test code that had become nonsensical over time - getContainerInstance was using the OS to choose between identical alternatives.
Plus some small tweaks to the worker to make it easier to test.
babbageclunk
force-pushed
the
machine-undertaker
branch
from
7467d55
to
1cde5c1
Compare
babbageclunk
force-pushed
the
machine-undertaker
branch
from
1cde5c1
to
cd398d9
Compare
|
|
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures any necessary provider-level cleanup is done before the machine is fully removed.
In particular, for containers in MAAS we need to release allocated addresses - the container provisioner can't do this because it has no way to talk to the provider directly. So now the provisioner task will mark the machine as ready for removal when its work is completed. This worker watches for the removal request, releases addresses for containers (where the provider supports it), and then removes the machine and associated records. It's expected that other provider-level cleanup like IP address management will be added here.
Fixes http://pad.lv/1585878.
QA steps:
(Review request: http://reviews.vapour.ws/r/5540/)