Source migration prechecks infrastructure #6088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| machine.Id(), machineVersion, modelVersion) | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
Do you want to add TODO comment for other prechecks?
There was a problem hiding this comment.
I had it in a text file but you're right that it would be better in the code. Done.
|
Looks like a good start. LGTM |
|
|
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
|
Build failed: Does not match ['fixes-1616584', 'fixes-1611514', 'fixes-1475212'] |
added 10 commits
August 25, 2016 13:27
The checks to perform on the source and target will be different and done separately.
Ensure that an upgrade isn't in progress by checking that all machines in the model have the same tools version as what's set for the model.
This wraps a *state.State to implement the interface required for migration prechecks.
A new Precheck method will run pre-migration checks on the model and source controller.
mjs
force-pushed
the
MM-source-prechecks
branch
from
34c15bb
to
bfc7159
Compare
|
|
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is mainly about adding the plumbing to support prechecks for the source controller and model. The infrastructure of target controller prechecks, as well as more precheck implementations, are coming.
Here we have: