Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/rework model defaults cli #6178

Merged
merged 3 commits into from Sep 8, 2016

Conversation

reedobrien
Copy link
Contributor

@reedobrien reedobrien commented Sep 7, 2016

Update tests accordingly.

Refs: juju-model-defaults-collapse

QA:

  1. All unit tests pass
  2. juju bootstrap reed-aws-west-1 awstest # with cloud like http://paste.ubuntu.com/23080517/
  3. juju model-defaults # verify that the output matches what you'd expect from the config above.
  4. juju model-defaults image-stream=develop test-mode=true # ensure settings are updated with juju model-config
  5. juju model-defaults --reset image-stream test-mode # ensure they are unset
  6. juju model-defaults image-stream
    ATTRIBUTE DEFAULT CONTROLLER
    image-stream released -
  7. juju model-defaults --format=json image-stream
    {"image-stream":{"default":"released"}}
  8. Maybe try a few more

(Review request: http://reviews.vapour.ws/r/5616/)

Refs: juju-model-config-collapse
Refs: juju-model-defaults-collapse
@reedobrien reedobrien force-pushed the feature/rework-model-defaults-cli branch from aca9207 to 42ef900 Compare September 7, 2016 19:26
@reedobrien
Copy link
Contributor Author

$$merge$$

@jujubot
Copy link
Collaborator

jujubot commented Sep 7, 2016

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

@reedobrien
Copy link
Contributor Author

reedobrien commented Sep 8, 2016

jujubot failed to merge in http://juju-ci.vapour.ws:8080/job/github-merge-juju/9120/console

Trying again

@jujubot jujubot merged commit 05f6ec0 into juju:master Sep 8, 2016
@reedobrien reedobrien deleted the feature/rework-model-defaults-cli branch September 8, 2016 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants