fixes 1554116 - show resource-get in help-tool #6200
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were two problems here. The first is that we weren't registering the resource-get command when running the client... buit we need to, so we can run help-tool.
This then revealed a second problem - help-tool was passing in a dummy hook context into the command creation function, and hoped it wasn't actually looking too closely at the value. Well, the resource-get command creation function was looking fairly closely at that value. Luckily, it doesn't really need to, so I delayed that until we actually run the command.
A better general solution (proposed by Andrew) would be to pass the hook context into Run itself, since it's really only information that should need to be looked at when the command is actually run. But that's a bigger change.
http://reviews.vapour.ws/r/5636/