Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove list-shares. #6234

Merged
merged 6 commits into from Sep 15, 2016
Merged

Remove list-shares. #6234

merged 6 commits into from Sep 15, 2016

Conversation

howbazaar
Copy link
Contributor

@howbazaar howbazaar commented Sep 13, 2016

Addresses http://pad.lv/1623097. User info is shown with show-model, list-shares is to be removed.

(Review request: http://reviews.vapour.ws/r/5670/)

Copy link
Contributor

@natefinch natefinch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a test review to see what's up

@@ -305,7 +305,6 @@ func registerCommands(r commandRegistry, ctx *cmd.Context) {
r.Register(model.NewDefaultsCommand())
r.Register(model.NewRetryProvisioningCommand())
r.Register(model.NewDestroyCommand())
r.Register(model.NewUsersCommand())
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good bye!

@@ -81,30 +81,6 @@ func (s *cmdModelSuite) TestRevokeModelCmdStack(c *gc.C) {
c.Assert(modelUser, gc.DeepEquals, description.UserAccess{})
}

func (s *cmdModelSuite) TestModelUsersCmd(c *gc.C) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yay deleting code!

@howbazaar
Copy link
Contributor Author

$$merge$$

@jujubot
Copy link
Collaborator

jujubot commented Sep 15, 2016

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

@jujubot jujubot merged commit 2bfa068 into juju:master Sep 15, 2016
@howbazaar howbazaar deleted the remove-list-shares branch September 15, 2016 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants