New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove list-shares. #6234
Remove list-shares. #6234
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a test review to see what's up
@@ -305,7 +305,6 @@ func registerCommands(r commandRegistry, ctx *cmd.Context) { | |||
r.Register(model.NewDefaultsCommand()) | |||
r.Register(model.NewRetryProvisioningCommand()) | |||
r.Register(model.NewDestroyCommand()) | |||
r.Register(model.NewUsersCommand()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good bye!
@@ -81,30 +81,6 @@ func (s *cmdModelSuite) TestRevokeModelCmdStack(c *gc.C) { | |||
c.Assert(modelUser, gc.DeepEquals, description.UserAccess{}) | |||
} | |||
|
|||
func (s *cmdModelSuite) TestModelUsersCmd(c *gc.C) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yay deleting code!
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
Addresses http://pad.lv/1623097. User info is shown with show-model, list-shares is to be removed.
(Review request: http://reviews.vapour.ws/r/5670/)