Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
provider/azure: update auth-types #6249
Conversation
|
QA
|
| credAttrAppPassword = "application-password" | ||
| + | ||
| + clientCredentialsAuthType cloud.AuthType = "service-principal-secret" | ||
| + deviceCodeAuthType cloud.AuthType = "interactive" |
natefinch
Sep 15, 2016
•
Edited 1 time
-
natefinch
Sep 15, 2016
Contributor
-
Sep 15, 2016
deviceCodeAuthType? I don't understand how that relates to interactive. Maybe a comment here would be appropriate.
axw
Sep 15, 2016
Member
"device code" and "client credentials" are the OAuth terms. I gave them names that would be more meaningful to a user. Added comments to the constants.
| + label := in.Label | ||
| + in = cloud.NewCredential(clientCredentialsAuthType, attrs) | ||
| + in.Label = label | ||
| + fallthrough |
axw
Sep 15, 2016
Member
Yeah, I was thinking we might need to do something for the resultant auth-type. I don't think we ever will, so updated.
|
$$merge$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
|
Build failed: Tests failed |
|
$$merge$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
axw commentedSep 15, 2016
We introduces two new auth-types, and deprecate
use of "userpass", for Azure. The userpass auth-type
is superseded by service-principal-secret, which is
identical except that it does not include the
tenant-id field. There is a new "interactive"
auth-type which is defined, but not yet supported.
If a user uses "userpass", they will receive a
warning explaining that it is deprecated, and what
they need to do to migrate. The credential will
continue to work, we'll just ignore the tenant-id.