Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clean up uniter downloads #6325

Merged
merged 7 commits into from Sep 27, 2016
Merged

clean up uniter downloads #6325

merged 7 commits into from Sep 27, 2016

Commits on Sep 26, 2016

  1. downloader: Big clean up 

    The Download and Downloader were unnecessarily complicated with more
than one way to do things and confused aborting of downloads.

- Check req.Verify closer to where it's used to minimise the possibility
  of mistakes.
- Fixed/removed racy tests for stopping downloads. This also shaved 10s
  of the package test runtime.
- Removed the use of both a tomb and a channel to abort.
  downloads. Downloads are now only aborted via a channel passed in at
  download start time.
- The downloaded file is now removed if verification fails.
- The download filename is passed around instead of using a *os.File
  which needs to be re-seeked back to the start of file all the time.
- Removed Downloader most tests which were actually functionality which
  is already being tested on Download.
    Menno Smits committed Sep 26, 2016
    Configuration menu
    Copy the full SHA
    4a88d70 View commit details
    Browse the repository at this point in the history

  2. downloader: Allow downloads to actually be aborted 

    Previously the calls waiting for a download to be finish could be
aborted but the downloads themselves would continue.
    Menno Smits committed Sep 26, 2016
    Configuration menu
    Copy the full SHA
    f376b9d View commit details
    Browse the repository at this point in the history

  3. downloader: Avoid noise in download error 

    Do't annotate to avoid unnecessary information in the error.
    Menno Smits committed Sep 26, 2016
    Configuration menu
    Copy the full SHA
    f1f40de View commit details
    Browse the repository at this point in the history

  4. worker/uniter/charm: Added ClearDownloads 

    This can be used to clear out any temporary download files that may be
hanging around in a unit's charm download directory.
    Menno Smits committed Sep 26, 2016
    Configuration menu
    Copy the full SHA
    f1a99c0 View commit details
    Browse the repository at this point in the history

  5. worker/uniter/charm: Test downloads are cleared

    Menno Smits committed Sep 26, 2016
    Configuration menu
    Copy the full SHA
    233b277 View commit details
    Browse the repository at this point in the history

  6. worker/uniter: Clear temp download files on start 

    The uniter will now clear any temporary charm download files for itself
when it starts. Although this shouldn't happen now, previous versions of
Juju could leave a signiciant amount of data behind from failed download
attempts.

Fixes https://bugs.launchpad.net/juju/+bug/1626304
    Menno Smits committed Sep 26, 2016
    Configuration menu
    Copy the full SHA
    52e5c73 View commit details
    Browse the repository at this point in the history

  7. worker/uniter/charm: Removed a reminder 

    This was actioned.
    Menno Smits committed Sep 26, 2016
    Configuration menu
    Copy the full SHA
    323502d View commit details
    Browse the repository at this point in the history