Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Remove deprecated streams directory #6441
Conversation
| @@ -61,21 +62,16 @@ use the --clean option. | ||
| Examples: | ||
| - generate metadata for "released" tools, looking in the "releases" directory: |
mjs
Oct 12, 2016
Contributor
Pretty sure this shouldn't said "releases" now. Can the default value (envtools.ReleasedStream) be substituted in?
| @@ -61,21 +62,16 @@ use the --clean option. | ||
| Examples: | ||
| - generate metadata for "released" tools, looking in the "releases" directory: | ||
| - | ||
| - juju metadata generate-tools -d <workingdir> | ||
| + juju metadata generate-tools -d <workingdir> | ||
| - generate metadata for "released" tools, looking in the "released" directory: |
mjs
Oct 12, 2016
Contributor
Not your change I know but can we get rid of the word "directory" in these examples. It's confusing.
It would be enough to just say:
- generate metadata for "released" tools
Also, in other help examples, the comments tend to start with #. Can you please make this consistent while you're in here?
| + - generate metadata for "proposed": |
|
$$merge$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
|
Build failed: Tests failed |
|
$$merge$$ somehow go wasn't installed for the test run. |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
|
Build failed: Tests failed |
|
Actual fix. $$merge$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
kat-co commentedOct 12, 2016
This addresses lp:1613858.
When running
juju metadata generate-tools, Juju would attempt to look in a deprecated path "releases" for tools to generate streams. If you specified a value in the--streamflag (e.g. "devel"), Juju would work correctly. This was because we set this flag to the 1.x default of "releases" (notice: not "released").This patch sets the default of the
streamflag to envtools.ReleasedStream to give some transparancy to the user and follow a more common idiom. This also fixes the bug.I also added some
errors.Tracearound error paths in the functions I touched.