Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
featuretests: API error handling in upgrade logins #6449
Conversation
| - err = apiState.APICall("Client", 1, "", "FullStatus", nil, &result) | ||
| - c.Assert(err, jc.ErrorIsNil) | ||
| + // This call should always work, but might fail if the apiserver | ||
| + // is restarting . If it fails just return the error so retries |
mjs
referenced this pull request
Oct 14, 2016
Merged
featuretests: API error handling in upgrade logins #6450
|
Wrong target |
mjs
closed this
Oct 14, 2016
mjs
deleted the
mjs:1619744-TestLoginsDuringUpgrade
branch
Oct 14, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
mjs commentedOct 14, 2016
The call to FullStatus was always expected to work but would occasionally fail if the apiserver worker was in the middle of being restarted. Instead of failing immediately allow retries to continue.
Fixes https://bugs.launchpad.net/juju/+bug/1619744