featuretests: API error handling in upgrade logins #6449
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
howbazaar
reviewed
Oct 14, 2016
| err = apiState.APICall("Client", 1, "", "FullStatus", nil, &result) | ||
| c.Assert(err, jc.ErrorIsNil) | ||
| // This call should always work, but might fail if the apiserver | ||
| // is restarting . If it fails just return the error so retries |
There was a problem hiding this comment.
s/restarting ./restarting./
howbazaar
approved these changes
Oct 14, 2016
The call to FullStatus was always expected to work but would occasionally fail if the apiserver worker was in the middle of being restarted. Instead of failing immediately allow retries to continue. Fixes https://bugs.launchpad.net/juju/+bug/1619744
mjs
force-pushed
the
1619744-TestLoginsDuringUpgrade
branch
from
c688b7f
to
3dc4596
Compare
|
Wrong target |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The call to FullStatus was always expected to work but would occasionally fail if the apiserver worker was in the middle of being restarted. Instead of failing immediately allow retries to continue.
Fixes https://bugs.launchpad.net/juju/+bug/1619744