apiserver: allow AllWatcher access even without controller login access #6453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rogpeppe
force-pushed
the
118-allow-allwatcher-model-access
branch
from
01b2528
to
6955008
Compare
frankban
approved these changes
Oct 14, 2016
A watcher is special in that it can't do anything unless a resource has already been created (with a Watch method). That means that the important place to check permissions is when the watcher resource is created, not when the watcher is used. The permission check removed here was both unnecesssary (as described above) and insufficient (the user might have login access to the controller but no access to the model being watched, for example).
rogpeppe
force-pushed
the
118-allow-allwatcher-model-access
branch
from
6955008
to
d6224d1
Compare
perrito666
approved these changes
Oct 14, 2016
|
!!build!! |
|
|
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A watcher is special in that it can't do anything unless a resource
has already been created (with a Watch method). That means
that the important place to check permissions is when the
watcher resource is created, not when the watcher is used.
The permission check removed here was both unnecesssary
(as described above) and insufficient (the user might have login
access to the controller but no access to the model being watched,
for example).