Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
api: fix intermittent test failures #6461
Conversation
| + for i, test := range openWithSNIHostnameTests { | ||
| + c.Logf("test %d: %v", i, test.about) | ||
| + s.testSNIHostName(c, test.info, test.expectDial) | ||
| + } | ||
| } | ||
| // testSNIHostName tests that when the API is dialed with the given info, | ||
| // api.newWebsocketDialer is called with the expected information | ||
| // (one element for each call to newWebsocketDialer) |
|
$$merge$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
jujubot
merged commit 809dc26
into
juju:develop
Oct 17, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
rogpeppe commentedOct 17, 2016
The test code assumed that we'd get dial requests in the
order they are specified, but in a heavily loaded test server
this is not necessarily the case, leading to failures like this one:
http://reports.vapour.ws/releases/4490/job/run-unit-tests-xenial-amd64/attempt/1427#highlight
This fixes the test so that we don't rely on the sequential try ordering - the
concurrent retry mechanism isn't something we need to test in this test,
so just connect to a single address in each test.