Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Use API server retry logic #6538
Conversation
dooferlad
changed the base branch from
staging
to
develop
Nov 3, 2016
dooferlad
changed the title from
Use API server the retry logic
to
Use API server retry logic
Nov 3, 2016
|
!!retry!! |
|
!!retry!! |
|
!!retry!! |
|
Anything between !! !! Will trigger a build. It seems like @gz, the bot doesn't like you :( |
|
!!weneedaretrythebotlikesme!! |
|
@nskaggs boo. The quick tests seem to be broken too :-( |
|
@dooferlad yea, looks like the upgrade just broke things. |
|
!!build!! |
kat-co
suggested changes
Nov 4, 2016
LGTM. Note: we might want to tweak this again as we may be standardizing on https://gopkg.in/retry.v1
| + | ||
| + if openAttempt.Min == 0 && openAttempt.Delay > 0 { | ||
| + openAttempt.Min = int(openAttempt.Total / openAttempt.Delay) | ||
| + } |
kat-co
Nov 4, 2016
Contributor
I would instead fail here. This is a great way to hide issues in calling code.
|
$$merge$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
jujubot
merged commit 9f44391
into
juju:develop
Nov 4, 2016
1 check passed
github-check-merge-juju
Built PR, ran unit tests, and tested LXD deploy. Use !!.*!! to request another build. IE, !!build!!, !!retry!!
Details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
dooferlad commentedNov 3, 2016
When connecting to the API server the retry logic didn't fire, which resulted in all the workers restarting after three seconds. The intent was obviously different. Will now try connecting every 200ms for a second. A pleasing side effect is that tests run much more quickly without 3 second pauses in them.
Tested by running the unit tests.