Use API server retry logic #6538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…resulted in all the workers restarting after three seconds. The intent was obviously different. Will now try connecting every 200ms for a second. A pleasing side effect is that tests run much more quickly without 3 second pauses in them.
|
!!retry!! |
2 similar comments
|
!!retry!! |
|
!!retry!! |
|
Anything between !! !! Will trigger a build. It seems like @gz, the bot doesn't like you :( |
|
!!weneedaretrythebotlikesme!! |
|
@nskaggs boo. The quick tests seem to be broken too :-( |
|
@dooferlad yea, looks like the upgrade just broke things. |
|
!!build!! |
kat-co
suggested changes
Nov 4, 2016
There was a problem hiding this comment.
LGTM. Note: we might want to tweak this again as we may be standardizing on https://gopkg.in/retry.v1
|
|
||
| if openAttempt.Min == 0 && openAttempt.Delay > 0 { | ||
| openAttempt.Min = int(openAttempt.Total / openAttempt.Delay) | ||
| } |
There was a problem hiding this comment.
I would instead fail here. This is a great way to hide issues in calling code.
|
|
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When connecting to the API server the retry logic didn't fire, which resulted in all the workers restarting after three seconds. The intent was obviously different. Will now try connecting every 200ms for a second. A pleasing side effect is that tests run much more quickly without 3 second pauses in them.
Tested by running the unit tests.