-
Notifications
You must be signed in to change notification settings - Fork 494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modifies the prompt for the cloud name to include cloud type #6632
Conversation
@@ -182,7 +186,7 @@ func queryName(cloudMetadataStore CloudMetadataStore, pollster *interact.Pollste | |||
} | |||
|
|||
for { | |||
name, err := pollster.Enter("a name for the cloud") | |||
name, err := pollster.Enter(fmt.Sprintf("a name for your %s", cloudType)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this clearer as "a name for your %s cloud". It's a little funny for 'maas', but makes more sense for 'manual' and is fine with 'openstack', 'vsphere', and so on.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea, implemented.
c024bbd
to
0e0411a
Compare
0e0411a
to
01d862d
Compare
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
Build failed: Tests failed |
Spurious error. |
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
Build failed: Tests failed |
Spurious error. |
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
Note that this is based upon this PR. Look at the latest commit for the (small) diff.