Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modifies the prompt for the cloud name to include cloud type #6632

Merged
merged 1 commit into from
Dec 1, 2016

Conversation

kat-co
Copy link
Contributor

@kat-co kat-co commented Nov 29, 2016

Note that this is based upon this PR. Look at the latest commit for the (small) diff.

@@ -182,7 +186,7 @@ func queryName(cloudMetadataStore CloudMetadataStore, pollster *interact.Pollste
}

for {
name, err := pollster.Enter("a name for the cloud")
name, err := pollster.Enter(fmt.Sprintf("a name for your %s", cloudType))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this clearer as "a name for your %s cloud". It's a little funny for 'maas', but makes more sense for 'manual' and is fine with 'openstack', 'vsphere', and so on.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, implemented.

@kat-co kat-co force-pushed the modify-prompt-cloudtype branch 2 times, most recently from c024bbd to 0e0411a Compare November 30, 2016 22:58
@kat-co
Copy link
Contributor Author

kat-co commented Nov 30, 2016

$$merge$$

@jujubot
Copy link
Collaborator

jujubot commented Nov 30, 2016

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

@jujubot
Copy link
Collaborator

jujubot commented Nov 30, 2016

Build failed: Tests failed
build url: http://juju-ci.vapour.ws:8080/job/github-merge-juju/9749

@kat-co
Copy link
Contributor Author

kat-co commented Dec 1, 2016

Spurious error.

$$merge$$

@jujubot
Copy link
Collaborator

jujubot commented Dec 1, 2016

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

@jujubot
Copy link
Collaborator

jujubot commented Dec 1, 2016

Build failed: Tests failed
build url: http://juju-ci.vapour.ws:8080/job/github-merge-juju/9750

@kat-co
Copy link
Contributor Author

kat-co commented Dec 1, 2016

Spurious error.

$$merge$$

@jujubot
Copy link
Collaborator

jujubot commented Dec 1, 2016

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

@jujubot jujubot merged commit 61acf3c into juju:develop Dec 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants