state: more error tracing and logging #666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -7,7 +7,6 @@ import ( | |||
| "fmt" | |||
| "sync" | |||
| "time" | |||
|
|
|||
There was a problem hiding this comment.
Yes, goimports strikes again :) Fixed.
|
LGTM with a small fix on an accidental deletion, although you need another one from my mentor dave |
|
LGTM |
… of finding the cause for CI bugs
dimitern
force-pushed
the
more-logging-and-error-tracing-in-state
branch
from
c0f896f
to
08f5f93
Compare
|
JFDI - Submitting despite the CI block with the hope to catch more context when errors happen on the bot. |
|
Trying again... |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
jujubot
added a commit
that referenced
this pull request
Sep 3, 2014
…in-state state: more error tracing and logging Added error tracing using the errors package and more logging with the hope of finding the cause for CI bugs. It does not fix lp:1348477 (auth fails), but hopefully will provide a lot more context why it happens on the bot.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added error tracing using the errors package and more logging with the hope of finding the cause for CI bugs.
It does not fix lp:1348477 (auth fails), but hopefully will provide a lot more context why it happens on the bot.