Remove juju-mongo in manual clean-up #6675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the manual provider bootstrap instance clean-up script, remove all juju-mongo packages after juju-db has been stopped.
|
ping @bz2 for peeking at this please and thank you |
bz2
approved these changes
Dec 8, 2016
| @@ -242,12 +242,13 @@ touch %s | |||
| # If jujud is running, we then wait for a while for it to stop. | |||
| stopped=0 | |||
| if pkill -%d jujud; then | |||
| for i in ` + "`seq 1 30`" + `; do | |||
| for i in {1..30}; do | |||
There was a problem hiding this comment.
Are we confident this is always bash?
:~$ dash
$ for i in {0..10}; do
> echo $i
> done
{0..10}
$ for i in `seq 1 10`; do
> echo $i
> done
1
2
...
`
There was a problem hiding this comment.
We are; /bin/bash is passed in to the ssh command to run this script.
|
!!build!! |
|
|
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the manual provider bootstrap instance clean-up script, remove all
juju-mongo packages after juju-db has been stopped.
QA steps:
bootstrapwith the manual providerdestroy-controllerdpkg -l juju-mongo*to see that none of the juju-mongo packages is still installedgrep jujud.*stopped /var/log/syslogto see some new logger output (hopefully the success case)