2.1 dynamic bridges log script output #6786

Merged
merged 7 commits into from Jan 10, 2017

Conversation

Projects
None yet
3 participants
Contributor

frobware commented Jan 9, 2017

We currently log the bridge script output only if there is an error. If there is no error, we still capture the output, but at trace level. It is useful to see the before/after configuration of routing and bridging when debugging problems.

Andrew McDermott added some commits Jan 9, 2017

bridgescript: log script output at trace level
We currently log the bridge script only if there is an error. If there
is no error, we still capture the output, but at trace level. It is
useful to see the before/after configuration of routing and bridging
when debugging problems.
Contributor

frobware commented Jan 10, 2017

!!build!!

Have you tested this live and feel like it gives useful context for debugging?

Contributor

frobware commented Jan 10, 2017

@jameinel - yes, tested live. It show us the current configuration for things we are about to change; /e/n/i, current bridges, current routes, current state of interfaces, then same again after we have bridged. The only small caveat I would mention is that /sometimes/ it shows the state of, say, br-en3 as DOWN. This is a timing issue because if you augment the output with a sleep, then ip -d link show you'll see that br-ens3 is actually UP.

Contributor

frobware commented Jan 10, 2017

$$meege$$

Contributor

jujubot commented Jan 10, 2017

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

@jujubot jujubot merged commit c1c8764 into juju:2.1-dynamic-bridges Jan 10, 2017

1 check passed

github-check-merge-juju Built PR, ran unit tests, and tested LXD deploy. Use !!.*!! to request another build. IE, !!build!!, !!retry!!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment