2.1 dynamic bridges log script output #6786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
January 9, 2017 15:11
We currently log the bridge script only if there is an error. If there is no error, we still capture the output, but at trace level. It is useful to see the before/after configuration of routing and bridging when debugging problems.
|
!!build!! |
jameinel
approved these changes
Jan 10, 2017
|
@jameinel - yes, tested live. It show us the current configuration for things we are about to change; /e/n/i, current bridges, current routes, current state of interfaces, then same again after we have bridged. The only small caveat I would mention is that /sometimes/ it shows the state of, say, br-en3 as DOWN. This is a timing issue because if you augment the output with a |
|
|
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently log the bridge script output only if there is an error. If there is no error, we still capture the output, but at trace level. It is useful to see the before/after configuration of routing and bridging when debugging problems.