upgrades: add Environ upgrade infrastructure #6818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce the environs.Upgrader interface, an optional interface that an Environ may implement to upgrade environments.
|
QA (along with some as-yet unpublished azure changes)
|
mjs
approved these changes
Jan 19, 2017
|
|
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
jujubot
added a commit
that referenced
this pull request
Jan 19, 2017
provider/azure: create common resources once only Create common resources (storage account, vnet, nsg) once only, when creating the model. For bootstrap, we do this along with the bootstrap machine as we already did. For non-controller models, we create a deployment for the common resources at model creation time. Because deployments can take a while, and model creation is synchronous, we do the common resource creation asynchronously and wait for its completion before starting any machines. There is an Environ upgrade step added that creates a common resource deployment in non-controller models. The upgrade step will preserve application- specific network security rules. Requires #6818 Fixes https://bugs.launchpad.net/juju/+bug/1656723
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce the environs.Upgrader interface, an
optional interface that an Environ may
implement to upgrade environments.
One significant logical change in this PR is that
we no longer short-circuit the upgrade steps
worker, when there are no upgrade operations
to execute. This change is due to the fact that
it is no longer possible to statically determine
a lack of upgrade operations, since there may
or may not be upgradeable Environs in the
controller.
This is part of the fix for https://bugs.launchpad.net/juju/+bug/1656723