apiclient: don't log at error level when dialing #6830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alesstimec
approved these changes
Jan 18, 2017
jameinel
approved these changes
Jan 18, 2017
| return conn, nil | ||
| } | ||
| if isX509Error(err) { | ||
| if certErr := isX509Error(err); !a.HasNext() || certErr { |
There was a problem hiding this comment.
isCertErr would be a clearer variable name to not make you think that this was an error object, but is a boolean.
| } | ||
| if !a.HasNext() { | ||
| logger.Errorf("error dialing %q: %v", cfg.Location, err) | ||
| logger.Debugf("error dialing %q (certificate error %v): %v", certErr, err) |
There was a problem hiding this comment.
what do you think about:
detail := ""
if isCertErr {
detail = " (bad certificate)"
}
logger.Debugf("error dialing %q%s: %v", cfg.Location, detail, err)
PR juju#6620 changed the client logging so that it logs an error when it can't connect to an API address. It is common for these errors to occur when connecting even though the actual connect succeeds, so this PR changes the logging to debug level - it's part of the implementation but not something that users should always see.
rogpeppe
force-pushed
the
122-no-error-logging-on-failed-dial
branch
from
5e4ac80
to
6f69b58
Compare
|
|
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
jujubot
added a commit
that referenced
this pull request
Feb 6, 2017
…-dial-2.1 apiclient: don't log at error level when dialing PR #6620 changed the client logging so that it logs an error when it can't connect to an API address. It is common for these errors to occur when connecting even though the actual connect succeeds, so this PR changes the logging to debug level - it's part of the implementation but not something that users should always see. This is a backport of #6830 to Juju 2.1, as the errors are confusing people and 2.2 won't be out for a while.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #6620 changed the client logging so that it logs an
error when it can't connect to an API address.
It is common for these errors to occur when connecting
even though the actual connect succeeds, so this
PR changes the logging to debug level - it's part
of the implementation but not something that users
should always see.