add SNAP bin path to bash completion #6927
Conversation
For snapped versions of Juju which reside in /snap/bin/juju we need to make bash completion aware of this additional binary path. Signed-off-by: Adam Stokes <battlemidget@users.noreply.github.com>
There was a problem hiding this comment.
With these changes, snap will take priority over installed Juju version. Just to be clear :)
If this is the intent, we should flag this with @juju/docs and release team @nskaggs
|
/usr/bin should probably come first. I wonder if we can just say which juju however? |
|
I'm not sure @nskaggs updated based on your suggestion, I'm still not sure about using |
Make sure /usr/bin/juju* has the priority over a snapped version. Signed-off-by: Adam Stokes <battlemidget@users.noreply.github.com>
|
Wouldn't it depend on what your $PATH is set to? (is it /usr/bin;/snap/bin; or is it /snap/bin;/usr/bin ?) So IMO, we should definitely prefer /usr/bin over /snap/bin. Because otherwise, if you have both installed you'll do "juju " and it will actually be /usr/bin/juju but you'll be doing tab completion on /snap/bin/juju, right? |
|
@jameinel Aside from the fallback to |
|
@jameinel right. Ubuntu sets path priority to debs over snaps. We should mirror the same here. Thanks. |
|
|
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
For snapped versions of Juju which reside in /snap/bin/juju we need to make bash
completion aware of this additional binary path.
Signed-off-by: Adam Stokes battlemidget@users.noreply.github.com
Please provide the following details to expedite Pull Request review:
Description of change
This change is needed to support an additional $PATH for snapped version of Juju.
QA steps
A new snap version of Juju or conjure-up needs to be built and then you can juju to verify completion still works.
Documentation changes
This does not require additional documentation.
Bug reference
No bug exists for this addition.