add SNAP bin path to bash completion

[battlemidget]

For snapped versions of Juju which reside in /snap/bin/juju we need to make bash
completion aware of this additional binary path.

Signed-off-by: Adam Stokes battlemidget@users.noreply.github.com

Please provide the following details to expedite Pull Request review:

---

Description of change

This change is needed to support an additional $PATH for snapped version of Juju.

QA steps

A new snap version of Juju or conjure-up needs to be built and then you can juju to verify completion still works.

Documentation changes

This does not require additional documentation.

Bug reference

No bug exists for this addition.

[anastasiamac]

With these changes, snap will take priority over installed Juju version. Just to be clear :)

If this is the intent, we should flag this with @juju/docs and release team @nskaggs

[nskaggs]

/usr/bin should probably come first. I wonder if we can just say which juju however?

[battlemidget]

I'm not sure which juju I would think that would be similar to doing /usr/bin/env. What's the overall consensus on using that version the absolute path?

@nskaggs updated based on your suggestion, I'm still not sure about using which juju so I stuck with absolute paths.

[nskaggs]

I think the new order this is fine. On the test request, this is a packaging only thing, not easily tested really.

[jameinel]

Wouldn't it depend on what your $PATH is set to? (is it /usr/bin;/snap/bin; or is it /snap/bin;/usr/bin ?)
On my system without personal tweaking (AFAIK) it is:
/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games:/snap/bin

So IMO, we should definitely prefer /usr/bin over /snap/bin. Because otherwise, if you have both installed you'll do "juju " and it will actually be /usr/bin/juju but you'll be doing tab completion on /snap/bin/juju, right?

[battlemidget]

@jameinel Aside from the fallback to /usr/bin/juju the order should be correct now. I don't think we should have the catch all be /snap/bin/juju though. I also took at look at $PATH on several vanilla installs and /snap/bin is the last item in $PATH.

[nskaggs]

@jameinel right. Ubuntu sets path priority to debs over snaps. We should mirror the same here. Thanks.

[nskaggs]

$$merge$$

[jujubot]

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju