Allow removal of store charms #7000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise the associated storage records in the blobstore never get removed, which means that the DB will contain every charm ever deployed on the controller, regardless of whether it's currently used. It's not clear why this was prevented - the comments don't really explain. Experimentation shows that we can reinstate removed charms if they're subsequently deployed again. This seems like a better trade-off - they're cached locally if there's anything using them (so adding units doesn't require getting the charm again) but they're not kept around forever, taking up space that isn't ever returned.
|
!!chittychitty!! |
|
Have you tried redeploying the same charm into the same model once it has been removed? Because that is what the comment seems to indicate. |
|
Oh, yes - I've tried that too. |
howbazaar
approved these changes
Feb 17, 2017
|
|
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Charm-store charms should be removed when they're no longer needed in
the same way as local charms. Otherwise the associated storage records in
the blobstore never get removed, which means that the DB will contain every
charm ever deployed on the controller, regardless of whether it's currently used.
It's not clear why this was prevented - the comments don't really
explain. Experimentation shows that we can reinstate removed charms if
they're subsequently deployed again. This seems like a better trade-off
doesn't require getting the charm again) but they're not kept around
forever, taking up space that isn't ever returned. (See the bug comments
for more discussion.)
QA steps
db.managedStoredResources.find({"path": {"$regex": "charm"}})Bug reference
Part of fixing https://bugs.launchpad.net/juju/+bug/1579976