apiserver/admin: Restrict user logins #702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
|
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
|
Build failed: Tests failed |
Any user login will fail unless that user exists in the environment.
waigani
force-pushed
the
login-environ-user-only
branch
2 times, most recently
from
45e47b2
to
37ee798
Compare
| func (s *loginSuite) TestNonEnvironUserLoginFails(c *gc.C) { | ||
| info, cleanup := s.setupServer(c) | ||
| defer cleanup() | ||
| user := s.Factory.MakeUser(c, &factory.UserParams{Password: "dummy-password"}) |
There was a problem hiding this comment.
this is going to fail now right? You'll need to update the user params to say "don't make an env user".
waigani
force-pushed
the
login-environ-user-only
branch
from
37ee798
to
23e2234
Compare
|
PTAL |
|
LGTM |
|
|
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
jujubot
added a commit
that referenced
this pull request
Sep 9, 2014
apiserver/admin: Restrict user logins Any user login will fail unless that user exists in the environment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Any user login will fail unless that user exists in the environment.