Remove core/description and use external repo. #7022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anastasiamac
approved these changes
Feb 23, 2017
|
|
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
|
The general rule there is to have a test that the two are in sync. It's ok
for tests to cross pollinate as long as the code itself doesn't.
Didn't we have one that would fail if you added/changed a database doc
without updating the description?
John
=:->
…On Feb 23, 2017 06:41, "anastasiamac" ***@***.***> wrote:
***@***.**** approved this pull request.
The change itself is awesome \o/
My concern is with the process, especially updates/deletes/additions...
I wonder how we can stay in sync, i.e. how we can ensure that we do not
forget to update this external package when we change core structures.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#7022 (review)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAMYfYr2zBTumgp7p8URX7czCqo4WYPiks5rfPHugaJpZM4MJdFR>
.
|
|
Ugh, I guess that means the changes I'm making to add remote applications to the description need to happen there now. |
|
Build failed: Tests failed |
|
|
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
|
We have tests in the state package to make sure things are migrated. The serialisation format is separate. |
|
Build failed: Tests failed |
|
|
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the new extraced juju/description package.