Remove core/description and use external repo.

[howbazaar]

Use the new extraced juju/description package.

[anastasiamac]

The change itself is awesome \o/
My concern is with the process, especially updates/deletes/additions...
I wonder how we can stay in sync, i.e. how we can ensure that we do not forget to update this external package when we change core structures.

[howbazaar]

$$merge$$

[jujubot]

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

[jameinel]

The general rule there is to have a test that the two are in sync. It's ok for tests to cross pollinate as long as the code itself doesn't. Didn't we have one that would fail if you added/changed a database doc without updating the description? John =:->

…

On Feb 23, 2017 06:41, "anastasiamac" ***@***.***> wrote: ***@***.**** approved this pull request. The change itself is awesome \o/ My concern is with the process, especially updates/deletes/additions... I wonder how we can stay in sync, i.e. how we can ensure that we do not forget to update this external package when we change core structures. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#7022 (review)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAMYfYr2zBTumgp7p8URX7czCqo4WYPiks5rfPHugaJpZM4MJdFR> .

[babbageclunk]

Ugh, I guess that means the changes I'm making to add remote applications to the description need to happen there now.

[jujubot]

Build failed: Tests failed
build url: http://juju-ci.vapour.ws:8080/job/github-merge-juju/10344

[howbazaar]

$$windows-mongo$$

[jujubot]

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

[howbazaar]

We have tests in the state package to make sure things are migrated. The serialisation format is separate.

[jujubot]

Build failed: Tests failed
build url: http://juju-ci.vapour.ws:8080/job/github-merge-juju/10359

[howbazaar]

$$intermittent-windows-again$$

[jujubot]

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju