cmd/jujud: synchronise state server upgrades #709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In preparation for upcoming upgrade changes: - machines created by primeAgent now have a pinger running so that EnsureAvailability can be used in tests to create additional state servers - separated machine configuration from creation in primeAgent to allow machines created through other means (e.g. EnsureAvailability) to still be configured for use with machine agents
| @@ -155,16 +184,24 @@ func (c *upgradeWorkerContext) runUpgrades() error { | |||
|
|
|||
| a := c.agent | |||
| tag := c.agentConfig.Tag().(names.MachineTag) | |||
There was a problem hiding this comment.
This line just gives me the heebie jeebies. Mostly because it panics if the tag isn't a machine tag.
I know it was there before, but we really prefer no panic possibilities in production code.
There was a problem hiding this comment.
You could argue that if a machine agent's tag isn't a MachineTag then things are so bad that panicking might be the best course of action :)
Still, I will change this.
|
looks pretty good, just a few questions |
Use state's UpgradeInfo to synchronise state server upgrades. Overview: - after restarting into a new tools version, master state servers will wait up to 15 minutes for any other state servers to indicate they are ready for upgrade. A downgrade to the previous tools version will occur if this wait times out. - secondary state servers will wait until the master has completed its upgrade (to allow DB schema migrations to happen first) - as state servers complete their upgrades they report this to the UpgradeInfo document. The document is archived once the last state server completes its upgrade.
|
LGTM |
|
|
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
jujubot
added a commit
that referenced
this pull request
Sep 9, 2014
cmd/jujud: synchronise state server upgrades
Use state's UpgradeInfo to synchronise state server upgrades. Overview:
- after restarting into a new tools version, master state servers will wait up to 15 minutes for any other state servers to indicate they are ready for upgrade. A downgrade to the previous tools version will occur if this wait times out.
- secondary state servers will wait until the master has completed its upgrade (to allow DB schema migrations to happen first)
- as state servers complete their upgrades they report this to the UpgradeInfo document. The document is archived once the last state server completes its upgrade.
Note that some refactoring to the implementation and tests is planned immediately after this PR lands. I didn't include them here because I didn't want to clutter up this PR any further.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use state's UpgradeInfo to synchronise state server upgrades. Overview:
Note that some refactoring to the implementation and tests is planned immediately after this PR lands. I didn't include them here because I didn't want to clutter up this PR any further.