Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Remove direct model cmr #7097
Conversation
wallyworld
added some commits
Mar 14, 2017
| + } | ||
| + | ||
| + var st *state.State | ||
| + fail := func(err error) ( |
| } | ||
| // Get the backend state for the source model so we can lookup the application. | ||
| - st, err := api.backend.ForModel(sourceModelTag) | ||
| + st, err = api.backend.ForModel(sourceModelTag) |
|
$$merge$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
|
Build failed: Tests failed |
|
$$merge$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
jujubot
merged commit 5c9f3ac
into
juju:develop
Mar 14, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
wallyworld commentedMar 14, 2017
Description of change
Please see the first commit.
The second commit is a drive by rename of service->application in the test suite.
We remove the ability to relate to other applications without first having that application offered in the remote model. Essentially we add a juju offer step to the workflow.
The work is essentially refactoring existing code and removing some now obsolete methods.
Note: there's still work required to fix the URL format and until that is done, juju offer is clumsy and requires a full URL to be specified even though it's not used.
QA steps
juju bootstrap
juju deploy mysql
juju offer mysql:db local:/u/me/hosted-mysql
juju switch controller
juju deploy mediawiki
juju relate mediawiki:db default.hosted-mysql