state: Make GetOwnerTag return names.UserTag #713
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| owner := s.doc.OwnerTag | ||
| if owner == "" { | ||
| // We know that if there was no owner, it was created with an early | ||
| // version of juju, and that admin was the only user. | ||
| owner = names.NewUserTag("admin").String() | ||
| owner = "admin" |
There was a problem hiding this comment.
return names.NewUserTag("admin")
Update service.GetOwnerTag() to return a names.UserTag instead of a string.
waigani
force-pushed
the
usertag-from-service
branch
from
661bd86
to
9be2839
Compare
|
PTAL |
|
LGTM, pending mentor approval @fwereade |
| @@ -620,14 +620,18 @@ func (s *Service) addUnitOps(principalName string, asserts bson.D) (string, []tx | |||
|
|
|||
| // SCHEMACHANGE | |||
| // TODO(mattyw) remove when schema upgrades are possible | |||
| func (s *Service) GetOwnerTag() string { | |||
| func (s *Service) GetOwnerTag() (names.UserTag, error) { | |||
There was a problem hiding this comment.
Please fix the comment on this method
make the method return names.Tag, error
|
LGTM with minor comments |
|
@howbazaar was in two minds whether to land this or remove GetOwnerTag altogether. @fwereade can you make the call please? |
|
No activity for a long time and no corresponding ReviewBoard diff. Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update service.GetOwnerTag() to return a names.UserTag instead of a
string.