Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

firewaller: Ensure ports get closed for old CIDRs #7270

Merged
merged 2 commits into from Apr 24, 2017

Conversation

babbageclunk
Copy link
Contributor

Description of change

Even if we're also opening them for another CIDR. This came up while
rejigging the GCE firewall handling - the firewaller would open the
ports for the new CIDR but not close them for the old one.

QA steps

  • Bootstrap and create 2 models with a cross-model relation in GCE
  • Stop and start a machine on the consuming side of the relation so that its public address changes.
  • When the new address is noticed and the firewall rules updated, check that the old address is removed from the firewall rule.

Even if we're also opening them for another CIDR. This came up while
rejigging the GCE firewall handling - the firewaller would open the
ports for the new CIDR but not close them for the old one.
@babbageclunk
Copy link
Contributor Author

!!build!!

@babbageclunk
Copy link
Contributor Author

$$merge$$

@jujubot
Copy link
Collaborator

jujubot commented Apr 24, 2017

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

@jujubot
Copy link
Collaborator

jujubot commented Apr 24, 2017

Build failed: Tests failed
build url: http://juju-ci.vapour.ws:8080/job/github-merge-juju/10736

@babbageclunk
Copy link
Contributor Author

Oops, build happened before my test fix got pushed.

$$merge$$

@jujubot
Copy link
Collaborator

jujubot commented Apr 24, 2017

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

@jujubot
Copy link
Collaborator

jujubot commented Apr 24, 2017

Build failed: Tests failed
build url: http://juju-ci.vapour.ws:8080/job/github-merge-juju/10741

@babbageclunk
Copy link
Contributor Author

Well, I don't understand what happened in that build - firewaller API tests timed out? I'm going to try again.

$$merge$$

@jujubot
Copy link
Collaborator

jujubot commented Apr 24, 2017

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

@jujubot jujubot merged commit b92f046 into juju:develop Apr 24, 2017
@babbageclunk babbageclunk deleted the close-ports branch April 24, 2017 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants