Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
firewaller: Ensure ports get closed for old CIDRs #7270
Conversation
|
!!build!! |
|
$$merge$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
|
Build failed: Tests failed |
|
Oops, build happened before my test fix got pushed. $$merge$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
|
Build failed: Tests failed |
|
Well, I don't understand what happened in that build - firewaller API tests timed out? I'm going to try again. $$merge$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
babbageclunk commentedApr 24, 2017
Description of change
Even if we're also opening them for another CIDR. This came up while
rejigging the GCE firewall handling - the firewaller would open the
ports for the new CIDR but not close them for the old one.
QA steps