firewaller: Ensure ports get closed for old CIDRs #7270

Merged
merged 2 commits into from Apr 24, 2017

Conversation

Projects
None yet
3 participants
Member

babbageclunk commented Apr 24, 2017

Description of change

Even if we're also opening them for another CIDR. This came up while
rejigging the GCE firewall handling - the firewaller would open the
ports for the new CIDR but not close them for the old one.

QA steps

  • Bootstrap and create 2 models with a cross-model relation in GCE
  • Stop and start a machine on the consuming side of the relation so that its public address changes.
  • When the new address is noticed and the firewall rules updated, check that the old address is removed from the firewall rule.
Ensure ports get closed for old CIDRs
Even if we're also opening them for another CIDR. This came up while
rejigging the GCE firewall handling - the firewaller would open the
ports for the new CIDR but not close them for the old one.
Member

babbageclunk commented Apr 24, 2017

!!build!!

Member

babbageclunk commented Apr 24, 2017

$$merge$$

Contributor

jujubot commented Apr 24, 2017

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

Contributor

jujubot commented Apr 24, 2017

Build failed: Tests failed
build url: http://juju-ci.vapour.ws:8080/job/github-merge-juju/10736

Member

babbageclunk commented Apr 24, 2017

Oops, build happened before my test fix got pushed.

$$merge$$

Contributor

jujubot commented Apr 24, 2017

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

Contributor

jujubot commented Apr 24, 2017

Build failed: Tests failed
build url: http://juju-ci.vapour.ws:8080/job/github-merge-juju/10741

Member

babbageclunk commented Apr 24, 2017

Well, I don't understand what happened in that build - firewaller API tests timed out? I'm going to try again.

$$merge$$

Contributor

jujubot commented Apr 24, 2017

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

@jujubot jujubot merged commit b92f046 into juju:develop Apr 24, 2017

1 check passed

github-check-merge-juju Built PR, ran unit tests, and tested LXD deploy. Use !!.*!! to request another build. IE, !!build!!, !!retry!!
Details

@babbageclunk babbageclunk deleted the babbageclunk:close-ports branch Apr 24, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment