cmd/juju/application: make deploy init tests assume less about internals #7274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rogpeppe
force-pushed
the
150-deploy-test-assume-less
branch
from
761c889
to
aaeffe9
Compare
|
!!build!! |
|
!!build!! |
babbageclunk
approved these changes
Apr 25, 2017
The tests are doing a deep-equal comparison of the deploy command, which assumes more than it should about what the state of the embedded objects. Make the code check the fields it cares about explicitly. Also clean up things a little bit: - NewDeployCommand is now the standard constructor, consistent with the other commands. - use runDeploy throughout, losing the hard-to-remember distinction between runDeploy and runDeployCommand.
rogpeppe
force-pushed
the
150-deploy-test-assume-less
branch
from
aaeffe9
to
78cd4a0
Compare
|
|
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests are doing a deep-equal comparison of the deploy
command, which assumes more than it should about what
the state of the embedded objects. Make the code check
the fields it cares about explicitly.
Also clean up things a little bit:
with the other commands.
between runDeploy and runDeployCommand.
QA check that the deploy command works.