/juju

cmd/juju/application: make deploy init tests assume less about internals #7274

Merged
merged 1 commit into from Apr 26, 2017

Conversation

Reviewers

@babbageclunk babbageclunk

@mhilton mhilton

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@rogpeppe @nskaggs @jujubot @babbageclunk @mhilton
@rogpeppe
Owner

rogpeppe commented Apr 25, 2017 •
Edited 1 time

The tests are doing a deep-equal comparison of the deploy
command, which assumes more than it should about what
the state of the embedded objects. Make the code check
the fields it cares about explicitly.

Also clean up things a little bit:

  • NewDeployCommand is now the standard constructor, consistent
    with the other commands.
  • use runDeploy throughout, losing the hard-to-remember distinction
    between runDeploy and runDeployCommand.

QA check that the deploy command works.
@rogpeppe
Owner

rogpeppe commented Apr 25, 2017

!!build!!
@mhilton

mhilton approved these changes Apr 25, 2017
View changes

LGTM

@nskaggs
Owner

nskaggs commented Apr 25, 2017

!!build!!
@babbageclunk

babbageclunk approved these changes Apr 25, 2017
View changes

Thanks, this seems much nicer.

@rogpeppe
cmd/juju/application: make deploy init tests assume less about internals 
The tests are doing a deep-equal comparison of the deploy
command, which assumes more than it should about what
the state of the embedded objects. Make the code check
the fields it cares about explicitly.

Also clean up things a little bit:
- NewDeployCommand is now the standard constructor, consistent
with the other commands.
- use runDeploy throughout, losing the hard-to-remember distinction
between runDeploy and runDeployCommand.
78cd4a0
@rogpeppe
Owner

rogpeppe commented Apr 26, 2017

$$merge$$
@jujubot
Contributor

jujubot commented Apr 26, 2017

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

@jujubot jujubot merged commit 0548895 into juju:develop Apr 26, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment