Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Fix the series selection logic for deploying local charms. #7285
Conversation
| +// | ||
| +// This type should really have a Validate method, as the force flag | ||
| +// is really only valid if the seriesFlag is specified. | ||
| +// There is code and tests that allow the force flag when series isn't |
|
$$merge$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
|
Build failed: Tests failed |
|
$$try-again$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
|
Build failed: Tests failed |
|
$$intermittent$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
|
Build failed: Tests failed |
|
$$merge$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
howbazaar commentedApr 27, 2017
Description of change
There was incorrect logic around old style local charms and the series that should be used by default.
The seriesSelector object now holds all that logic. Precedence is as follows:
QA steps
This will fix our CI test failures where they are deploying an old style charm with no series specified in the metadata.