Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Combine applicationoffers and remoteendpoints facades onto a single controller facade #7286
Conversation
wallyworld
changed the title from
Combine applicationoffers and remoteendpoints facades onto a single controller facade
to
[WIP] Combine applicationoffers and remoteendpoints facades onto a single controller facade
Apr 27, 2017
|
It's probably worth explaining why you've done it as well. |
wallyworld
changed the title from
[WIP] Combine applicationoffers and remoteendpoints facades onto a single controller facade
to
Combine applicationoffers and remoteendpoints facades onto a single controller facade
May 10, 2017
babbageclunk
approved these changes
May 10, 2017
Looks nice - the grant/revoke changes were much simpler than I expected.
|
$$merge$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
jujubot
merged commit d84b809
into
juju:develop
May 10, 2017
1 check failed
github-check-merge-juju
Built PR, ran unit tests, and tested LXD deploy. Use !!.*!! to request another build. IE, !!build!!, !!retry!!
Details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
wallyworld commentedApr 27, 2017
•
Edited 1 time
-
wallyworld
May 10, 2017
Description of change
Most of this is literally cut and paste, plus tweaks to make the list-offers and offer commands controller commands and not model commands. The cut and paste is copying code from the remoteendpoints api and apiserver packages into the corresponding applicationoffer packages.
The APIs on the remoteendpoints and applicationoffers facades are consolidated to the one facade, which is made a controller facade. Common apiserver code which was used by both previous facades is moved into the same package as the single, remaining facade.
This change is to allow offers to be correctly managed across controllers and (eventually) in JAAS.
QA steps
bootstrap and run a CMR scenario, checking that the various CLI commands work as expected.