Combine applicationoffers and remoteendpoints facades onto a single controller facade #7286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wallyworld
changed the title
|
It's probably worth explaining why you've done it as well. |
wallyworld
force-pushed
the
offers-controller-facade
branch
from
92571a4
to
903e8c6
Compare
wallyworld
force-pushed
the
offers-controller-facade
branch
from
903e8c6
to
aa6835a
Compare
wallyworld
changed the title
babbageclunk
approved these changes
May 10, 2017
|
|
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Most of this is literally cut and paste, plus tweaks to make the list-offers and offer commands controller commands and not model commands. The cut and paste is copying code from the remoteendpoints api and apiserver packages into the corresponding applicationoffer packages.
The APIs on the remoteendpoints and applicationoffers facades are consolidated to the one facade, which is made a controller facade. Common apiserver code which was used by both previous facades is moved into the same package as the single, remaining facade.
This change is to allow offers to be correctly managed across controllers and (eventually) in JAAS.
QA steps
bootstrap and run a CMR scenario, checking that the various CLI commands work as expected.