environs: Add Networking.ProviderSpaceInfo and .IsSpaceRoutable #7291
Conversation
babbageclunk
changed the title
|
Not sure about the names. Also, while typing the description I got confused - is it sensible to talk about routability between an |
environs/networking.go
Outdated
| // ProviderSpaceInfo returns the details of the space requested as | ||
| // a ProviderSpaceInfo. This will contain everything needed to | ||
| // decide whether an Environ of the same type in another | ||
| // controller could route to the space. If "" is passed as |
There was a problem hiding this comment.
Can we define a const DefaultSpace or something for ""
Or maybe we have one. But if not, we should.
There was a problem hiding this comment.
Yeah, good point, I'll dig one up/create one.
environs/networking.go
Outdated
|
|
||
| // IsRoutable returns whether this Environ can connect to the | ||
| // given space via cloud-local addresses. | ||
| IsRoutable(targetSpace ProviderSpaceInfo) (bool, error) |
There was a problem hiding this comment.
And then targetSpace would become a pointer also.
There was a problem hiding this comment.
Is this the second comment to one that never got added? I'm guessing it was "make ProviderSpaceInfo return a pointer"?
Will do on both counts.
environs/networking.go
Outdated
|
|
||
| // IsRoutable returns whether this Environ can connect to the | ||
| // given space via cloud-local addresses. | ||
| IsRoutable(targetSpace ProviderSpaceInfo) (bool, error) |
There was a problem hiding this comment.
maybe put Space in the name somewhere? IsSpaceRoutable?
environs/networking.go
Outdated
| type ProviderSpaceInfo struct { | ||
| network.SpaceInfo | ||
|
|
||
| // This identifies the cloud containing the space. Care must be |
There was a problem hiding this comment.
I'm still not convinced that we need any structure around the information. This is better than the layer above passing it in, but some of the bits in CloudSpec are never going to be relevant: IdentityEndpoint, StorageEndpoint.
I guess my only question is: do we think we'll ever want to use the CloudSpec field outside the provider? Maybe show which cloud/region a remote model is in to the user? Then some structure would be useful. But within the provider, the provider creates the information so it can apply its own structure to it.
There was a problem hiding this comment.
I don't really have a strong opinion about this. In the implementation it's more convenient to work with fields that have a defined type rather than pulling everything from a map[string]interface{} and do checking for presence and type. It seems like every cloud is going to care about type, name, region and credential, with endpoint being useful for non-built-in clouds. You're right that identity and storage endpoints are very unlikely to be useful, though.
I can also see that having the structure is kind of inviting the client code to look at it (although I guess it could be private).
There was a problem hiding this comment.
In a hangout Andrew pointed out that having a CloudSpec that wasn't quite a real CloudSpec was likely to bite us at some point (by some provider not scrubbing secrets and just using its real CloudSpec, for example). Changed the ProviderSpaceInfo just to have CloudType and everything else will live inside ProviderAttributes.
|
@babbageclunk possibly keep this bug in mind while you are poking around here |
These will be used when setting up cross-model relations to determine whether connections should use the cloud-local or public address for units.
babbageclunk
force-pushed
the
provider-remote-details
branch
from
74d8ae4
to
1e7d4dc
Compare
babbageclunk
changed the title
|
I'm landing this for now, given that the sprint in Montreal is understandably making it hard for people to get to this - @jameinel if you have suggestions or changes later I'll gladly make them in a subsequent PR. |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
Description of change
These new methods on the provider networking interface will be used when setting up cross-model relations to determine whether connections can use the cloud-local address for communication between units, or if they need to fall back to using the public address.
ProviderSpaceInfogets all the information that might be needed about a space in this environ to allow a different environ to determine whether it is directly accessible.IsSpaceRoutabletakes aProviderSpaceInfo(which will have been obtained from a different environ) and returns whether the cloud-local address can be used.This adds dummy implementations to all the existing NetworkingEnviron types. Followup PRs will implement the methods for different providers.
QA steps
None yet - these will be used in the API when creating cross-model relations.