all: disable mongo SSL where not necessary #7297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
For tests that require Mongo to be running, disable SSL except integration and end-to-end tests (e.g. in the jujud/agent and feature tests). Disabling SSL speeds up the tests significantly. In my testing, the state package takes ~500 seconds with SSL, and ~170 seconds without.
axw
force-pushed
the
disable-mongo-ssl-tests
branch
from
9981e0d
to
bbdbb37
Compare
|
Build failed: Generating tarball failed |
|
|
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
For tests that require Mongo to be running,
disable SSL except integration and end-to-end
tests (e.g. in the jujud/agent and feature
tests). Disabling SSL speeds up the tests
significantly. In my testing, the state
package takes ~500 seconds with SSL, and
~170 seconds without.
This branch updates to a newer juju/testing,
which defaults the storage engine to mmapv1.
QA steps
Run the tests.
Documentation changes
None.
Bug reference
None.