Fix LP:#1696828 by sanitizing meter status code inputs on import. #7478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I was able to reproduce the issue by attempting the migration from a 2.1.3 controller to 2.2-rc1. With the above fix, the migration succeeded. |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
jujubot
added a commit
that referenced
this pull request
Jun 9, 2017
Fix LP:#1696828 by sanitizing meter status code inputs on import. __Cherry-picking #7478 into develop__ ## Description of change > Why is this change needed? Meter status codes need to be sanitized to a set of enumerated values before setting them in state during a model migration. ## QA steps > How do we verify that the change works? Export a model from a 2.1.3 controller and import into a 2.2-rc1 controller, per [LP:#1696828](https://bugs.launchpad.net/juju/+bug/1696828). ## Documentation changes > Does it affect current user workflow? CLI? API? No. ## Bug reference > Does this change fix a bug? Please add a link to it. [LP:#1696828](https://bugs.launchpad.net/juju/+bug/1696828)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Meter status codes need to be sanitized to a set of enumerated values before setting them in state during a model migration.
QA steps
Export a model from a 2.1.3 controller and import into a 2.2-rc1 controller, per LP:#1696828.
Documentation changes
No.
Bug reference
LP:#1696828