/juju

Fix LP:#1696828 by sanitizing meter status code inputs on import. #7478

Merged
merged 1 commit into from Jun 9, 2017

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@cmars @jujubot
@cmars
Owner

cmars commented Jun 8, 2017

Description of change

Why is this change needed?

Meter status codes need to be sanitized to a set of enumerated values before setting them in state during a model migration.

QA steps

How do we verify that the change works?

Export a model from a 2.1.3 controller and import into a 2.2-rc1 controller, per LP:#1696828.

Documentation changes

Does it affect current user workflow? CLI? API?

No.

Bug reference

Does this change fix a bug? Please add a link to it.

LP:#1696828
@cmars
Owner

cmars commented Jun 8, 2017

@mitechie @nskaggs PTAL

@cmars cmars referenced this pull request Jun 9, 2017

Merged

Fix LP:#1696828 by sanitizing meter status code inputs on import. #7479

@cmars
Owner

cmars commented Jun 9, 2017

I was able to reproduce the issue by attempting the migration from a 2.1.3 controller to 2.2-rc1. With the above fix, the migration succeeded. $$merge$$
@jujubot
Contributor

jujubot commented Jun 9, 2017

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

@jujubot jujubot merged commit e8bc3c0 into juju:2.2 Jun 9, 2017
1 check passed

1 check passed

github-check-merge-juju Ran tests against PR. Use !!.*!! to request another build. IE, !!build!!, !!retry!!
Details

jujubot added a commit that referenced this pull request Jun 9, 2017

@jujubot
Merge pull request #7479 from cmars/lp1696828-develop 
Fix LP:#1696828 by sanitizing meter status code inputs on import.

__Cherry-picking #7478 into develop__

## Description of change

> Why is this change needed?

Meter status codes need to be sanitized to a set of enumerated values before setting them in state during a model migration.

## QA steps

> How do we verify that the change works?

Export a model from a 2.1.3 controller and import into a 2.2-rc1 controller, per [LP:#1696828](https://bugs.launchpad.net/juju/+bug/1696828).

## Documentation changes

> Does it affect current user workflow? CLI? API?

No.

## Bug reference

> Does this change fix a bug? Please add a link to it.

[LP:#1696828](https://bugs.launchpad.net/juju/+bug/1696828)
1cb9c09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment