Refresh controller in local store when doing show-controller #7573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameinel
approved these changes
Jun 30, 2017
| @@ -85,7 +85,7 @@ controllers: | |||
| current-model: controller | |||
| mallards: | |||
| models: | |||
| controller: | |||
| model0: | |||
| for i, m := range allModels { | ||
| modelTags[i] = names.NewModelTag(m.UUID) | ||
| if m.Name == bootstrap.ControllerModelName { |
There was a problem hiding this comment.
So is this just because from the client side we don't know the controller UUID?
should we be opening a bug that we should be returning that information earlier so that we don't have to infer it from the bootstrap name?
There was a problem hiding this comment.
| @@ -71,7 +71,7 @@ mallards: | |||
| cloud: mallards | |||
| agent-version: 999.99.99 | |||
| models: | |||
| controller: | |||
| model0: | |||
|
|
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
juju list-controllers will show outdated information until someone launches it with --refresh. Since when doing show-controller we have all the necessary information to refresh the state - do it.
Why is this change needed?
QA steps
Documentation changes
None
Bug reference
https://bugs.launchpad.net/juju/+bug/1634847