worker/modelupgrade: set model status #7609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wallyworld
approved these changes
Jul 10, 2017
worker/modelupgrader/worker.go
Outdated
| @@ -174,8 +189,14 @@ func newUpgradeWorker(config Config, targetVersion int) (worker.Worker, error) { | |||
| targetVersion, | |||
| setVersion, | |||
| ); err != nil { | |||
| if err := setStatus(status.Error, "failed to upgrade environ"); err != nil { | |||
There was a problem hiding this comment.
what not include the error in the status message?
There was a problem hiding this comment.
I thought it might be TMI for non-controller admins. I'll include it, we can change based on feedback.
Set model status before and after upgrading the model's environ. Allow the "error" status for models, so that we can indicate that the model requires attention (e.g. credentials are out of date and need to be refreshed.)
axw
force-pushed
the
modelupgrader-setstatus
branch
from
b5a55f5
to
4ffe441
Compare
|
|
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Set model status before and after upgrading the
model's environ. Allow the "error" status for
models, so that we can indicate that the model
requires attention (e.g. credentials are out of
date and need to be refreshed.)
QA steps
Documentation changes
None.
Bug reference
https://bugs.launchpad.net/juju/+bug/1700451