Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes lp#1700697: test failure on windows. #7619

Merged
merged 1 commit into from
Jul 11, 2017
Merged

Fixes lp#1700697: test failure on windows. #7619

merged 1 commit into from
Jul 11, 2017

Conversation

anastasiamac
Copy link
Contributor

Description of change

Test failure on windows: expected commands need '.exe' appended too.

QA steps

HelpToolSuite.TestHelpTool passes on windows.

Documentation changes

Does it affect current user workflow? CLI? API?

Bug reference

https://bugs.launchpad.net/juju/+bug/1700697

jameinel
jameinel approved these changes Jul 11, 2017
View reviewed changes
Copy link
Member

@jameinel jameinel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need a 2.2 target, or this change only exists on 2.3?

@anastasiamac
Copy link
Contributor Author

$$merge$$
The change is only on develop. It did not make 2.2 cut.

@jujubot
Copy link
Collaborator

jujubot commented Jul 11, 2017

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

@jujubot jujubot merged commit 2929f66 into juju:develop Jul 11, 2017
@anastasiamac anastasiamac deleted the help-tool-test-lp1700697 branch July 11, 2017 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jameinel jameinel jameinel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@anastasiamac @jujubot @jameinel