Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Move resource/cmd under cmd/juju/resource #7680
Conversation
mjs
approved these changes
Jul 28, 2017
Thanks for breaking this up into manageable pieces.
|
$$merge$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
jujubot
merged commit 7effc9c
into
juju:develop
Jul 28, 2017
1 check passed
github-check-merge-juju
Use !!.*!! to request another build. IE, !!build!!, !!retry!!
Details
anastasiamac
deleted the
anastasiamac:move-resources-cmd
branch
Jul 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
anastasiamac commentedJul 28, 2017
Description of change
This is the first bit of work to bring resources commands under common architecture breaking away from components' one.
This PR contains straightforward, mechanical move of resource/cmd to cmd/juju/resource. It also brings in the fix for a panic (lp#1699607).
The follow up PRs will address actually removing registration of these commands from components/all and registering them as all other juju commands; using an accessor function on the list resources commands for resource listener; adding feature tests subset.
QA steps
All resources commands run the same - 'juju charm resources ', 'juju resources ', 'juju resources ', 'juju attach'.
Documentation changes
n/as as this is an internal change
Bug reference
First step to address: https://bugs.launchpad.net/juju/+bug/1706809
Brings in the fix into 2.3-alpha1 for: https://bugs.launchpad.net/juju/+bug/1699607