Move resource/cmd under cmd/juju/resource #7680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjs
approved these changes
Jul 28, 2017
|
|
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
wallyworld
approved these changes
Jul 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
This is the first bit of work to bring resources commands under common architecture breaking away from components' one.
This PR contains straightforward, mechanical move of resource/cmd to cmd/juju/resource. It also brings in the fix for a panic (lp#1699607).
The follow up PRs will address actually removing registration of these commands from components/all and registering them as all other juju commands; using an accessor function on the list resources commands for resource listener; adding feature tests subset.
QA steps
All resources commands run the same - 'juju charm resources ', 'juju resources ', 'juju resources ', 'juju attach'.
Documentation changes
n/as as this is an internal change
Bug reference
First step to address: https://bugs.launchpad.net/juju/+bug/1706809
Brings in the fix into 2.3-alpha1 for: https://bugs.launchpad.net/juju/+bug/1699607