Added resources commands sanity check. #7691
Conversation
| charmOne := s.AddTestingCharm(c, s.charmName) | ||
|
|
||
| var err error | ||
| s.appOne, err = s.State.AddApplication(state.AddApplicationArgs{ |
There was a problem hiding this comment.
Using the factory is preferable here since there's no error checking required - the factory does it. Plus it's the preferred way of creating test entities.
There was a problem hiding this comment.
Great catch \o/
It actually means that I now get a result for 'juju resources ' :D Of course, the downside of this is that I now discovered another command which output needs to be ordered to produce deterministic output.
I'll propose it as a separate PR and land it first prior to this one.
| } | ||
|
|
||
| func (s *stubCharmStore) ListResources(charms []charmstore.CharmID) ([][]charmresource.Resource, error) { | ||
| s.stub.AddCall("ListResources", charms) |
There was a problem hiding this comment.
If the call is being recorded, it should be checked in a test somewhere.
Doing so would be a light weight way of making these tests a little more comprehensive.
There was a problem hiding this comment.
This check is done at line 106...
|
!!build!! |
|
|
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
Description of change
This is a basic sanity check, desired for test coverage.
Historically, resources commands where not tested for full-stack connectivity. This omission caused several slippages during refactoring and improvements of juju commands.
With the addition of a basic feature test, these slippages should no longer occur.
This test does not test the actual functionality and behavior of the commands. It traverses full stack to ensure all components are wired in.
QA steps
Feature test runs successfully.
Documentation changes
n/a, internal change
Bug reference
Final part for https://bugs.launchpad.net/juju/+bug/1706809