fix the overwriting of bootstrapConstraints #7714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aints original code is overwriting refined variable bootstrapConstraints to only mem=3584M, this ignores constraints setting
howbazaar
changed the title
howbazaar
approved these changes
Aug 10, 2017
|
|
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When doing restore-backup, BootstrapConstraints is NIL
in this case, original code is overwriting refined variable bootstrapConstraints to
only mem=3584M, even if ModelConstraints are set.
this ignores constraints setting
QA steps
How do we verify that the change works?
restore-backup with constraints(with -b option)
Bug reference
https://bugs.launchpad.net/juju/+bug/1641232
https://bugs.launchpad.net/juju/+bug/1641224